Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug: cannot report total kernel time when use command "-unified-gpus" #79

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Fix bug: cannot report total kernel time when use command "-unified-gpus" #79

merged 1 commit into from
Jul 5, 2024

Conversation

DX990307
Copy link
Contributor

@DX990307 DX990307 commented Jul 5, 2024

No description provided.

@DX990307 DX990307 linked an issue Jul 5, 2024 that may be closed by this pull request
total_kernel_time = 0 when using unified-gpus #78
Closed
@DX990307 DX990307 requested a review from syifan July 5, 2024 17:57
@syifan syifan changed the title fix bug Fix the bug that total_kernel_time=0 when unified-gpus argument is used Jul 5, 2024
@syifan syifan merged commit 5d49f87 into v3 Jul 5, 2024
18 checks passed
@DX990307
Copy link
Contributor Author

DX990307 commented Jul 6, 2024

This problem happens due to the function addKernelTimeTracer. This function traces kernel time when the driver processes task *driver.LaunchKernelCommand. If we use args”-gpus”, the driver will not trace the driver’s kernel time since the driver processes task *driver.LaunchUnifiedMultiGPUKernelCommand.

@DX990307 DX990307 changed the title Fix the bug that total_kernel_time=0 when unified-gpus argument is used Fix bug: cannot report total kernel time when use command "-unified-gpus" Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syifan syifan syifan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

total_kernel_time = 0 when using unified-gpus
2 participants
@DX990307 @syifan