Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unneeded fallback code #342

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

MichaelDeBoey
Copy link
Contributor

As @PaperStrike mentioned in #337 (comment)

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2021

Codecov Report

Merging #342 (18248f6) into master (e95f4ad) will increase coverage by 1.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #342      +/-   ##
===========================================
+ Coverage   98.45%   100.00%   +1.54%     
===========================================
  Files           9         9              
  Lines         194       185       -9     
===========================================
- Hits          191       185       -6     
+ Misses          3         0       -3     
Impacted Files Coverage Δ
src/lib/rule-finder.js 100.00% <100.00%> (+4.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e95f4ad...18248f6. Read the comment docs.

@ljharb ljharb changed the title chore: cleanup rule-finder.js refactor: remove unneeded fallback code Nov 8, 2021
@ljharb ljharb merged commit 18248f6 into sarbbottam:master Nov 8, 2021
@MichaelDeBoey MichaelDeBoey deleted the patch-1 branch November 8, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants