feat(preconditions): export all core preconditions #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lioness100
requested review from
favna,
kyranet and
vladfrangu
as code owners
favna
requested changes
Nov 12, 2021
| export type { CooldownContext } from './preconditions/Cooldown'; | ||
| export { CorePrecondition as ClientPermissionsCorePrecondition } from './preconditions/ClientPermissions'; |
There was a problem hiding this comment.
Restore this please, because otherwise this would be a breaking change.
Then add above the exports line:
/**
* @deprecated. Please use `CorePreconditions.ClientPermissions`. `ClientPermissionsCorePrecondition` will be removed in v3.0.0
*/There was a problem hiding this comment.
Yeah, I was thinking about doing that but didn't know what constituted as a breaking change. This would be an incredibly silly thing to bump to v3 over LMAO. 👍
There was a problem hiding this comment.
Basically anything that well.. could break someones code.. is a breaking change. If someone is using this import, they updated to the latest minor version (that till will be) either by choice or through caret semver and then run their bot it shouldn't crash because it can't find an import. That would happen when removing this, ergo it's a breaking change.
favna
approved these changes
Nov 13, 2021
favna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow extensions of core preconditions via
CorePreconditions.*. See also #320.The code changes themselves are self-explanatory. One change that will affect users is that
ClientPermissionsCorePreconditionwill now be accessible viaCorePreconditions.ClientPermissions.