Bugfix: Fix scrolling and bounds clamping #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it aligned at all scales when using a scroll wheel to zoom; on trackpad, it only really works when fully zoomed out.
Gtk Scrolled Windows have a kinetic scroll controller that always updates the adjustments when the scroll stops, which for some reason snaps the viewport to the top left. I couldn't figure out how to stop the events from triggering, so I just ignored updates from external sources for a second after zooming, which acheives the intended effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the viewport would prevent scrolling inside the top left corner of the image, preventing viewing the bottom or right sides. This is backwards, and this update fixes it so scrolling is allowed anywhere inside the image, and panning beyond the borders can be done at any time. It also ensures that at least the top left corner is aligned to the pixel grid, ensuring a proper view when fully zoomed out.