Skip to content

Conversation

@saphaljha
Copy link
Owner

Original Pull Request

magento#19408

Description (*)

Fixed issue - magento#19346
Import data 2.2.6 Value for 'product_type' attribute contains incorrect value

Since 'product_attribute' is reserved attribute,so we can restrict this type of attribute to be created by user.

Fixed Issues (if relevant)

Fixed issue - magento#19346
Import data 2.2.6 Value for 'product_type' attribute contains incorrect value

Manual testing scenarios (*)

  1. create an attribute with code product_type http://i.prntscr.com/AwUJuhizQKatBwNwRa1S7Q.png with type: dropdown scope: global sortable, comparable: no
  2. add it to a family and create a product.
  3. go to import profiles download sample file then reimport sample file

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@saphaljha saphaljha merged commit e5dc652 into 2.2-develop Dec 22, 2018
@saphaljha saphaljha deleted the 2.2-develop-PR-port-19408 branch January 14, 2019 03:06
saphaljha pushed a commit that referenced this pull request Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants