Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"touchéd" is not the correct form of "touched" #1

Closed
docwhat opened this issue May 19, 2019 · 2 comments · Fixed by #2
Closed

"touchéd" is not the correct form of "touched" #1

docwhat opened this issue May 19, 2019 · 2 comments · Fixed by #2
Labels
bug help wanted released

Comments

@docwhat
Copy link
Contributor

docwhat commented May 19, 2019

The word "touchéd" is not a real word. It isn't the correct form of "touched".

Incorrect usage of the word: “touched”, use “touchéd” instead diacritics
@sapegin
Copy link
Owner

sapegin commented May 19, 2019

Feel free to send a pull request with a fix. Probably adding \\b to the pattern should be enough.

@docwhat docwhat mentioned this issue May 19, 2019
Merged
sapegin pushed a commit that referenced this issue Jun 12, 2019
@docwhat @sapegin
Fix: Only honor explicitly listed suffixes (#2)
f59b2cf 
To prevent false positives like touched → touchéd.

Fixes #1
sapegin pushed a commit that referenced this issue Jun 13, 2019
Changelog: 🚀
6c865f7 
## Breaking changes

* Minimum supported Node version is 8.6

## Bug fixes

* Only honor explicitly listed suffixes ([#2](#2)), closes [#1](#1)
sapegin pushed a commit that referenced this issue Jun 14, 2019
Changelog: 🚀
dae4cd3 
## Breaking changes

* Minimum supported Node version is 8.6

## Bug fixes

* Only honor explicitly listed suffixes ([#2](#2)), closes [#1](#1)
@sapegin
Copy link
Owner

sapegin commented Jun 14, 2019

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: touched vs. touche
2 participants
@docwhat @sapegin