Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Year abbreviations #13

Closed
groenroos opened this issue Nov 23, 2022 · 3 comments · Fixed by #30
Closed

Year abbreviations #13

groenroos opened this issue Nov 23, 2022 · 3 comments · Fixed by #30
Labels
help wanted released

Comments

@groenroos
Copy link
Contributor

Sometimes years are abbreviated by omitting the first two digits, like so;

Salesforce Winter ’22
The Class of ’92
Summer of ’69

According to this reference, the correct apostrophe to use for these year abbreviations is ’. However, using ', or ‘ doesn't currently trigger an error with this rule.
@sapegin
Copy link
Owner

sapegin commented Nov 28, 2022

Hey, I personally dislike them: saving one character is not worth reduced readability. However, feel free to send a pull request with a fix.

@groenroos groenroos mentioned this issue Jan 24, 2024
Merged
@groenroos
Copy link
Contributor Author

@sapegin Agreed, it's not my favourite writing style either - but it's sometimes unavoidable, and I think the linter should pick it up. I've opened #30 to fix this!

sapegin pushed a commit that referenced this issue Jan 25, 2024
@groenroos
feat: Support year abbreviations (#30)
2187663 
Support using the correct apostrophe style (`’`) for two-digit year abbreviations (e.g. `Summer of ’69`)

Ensures that other similar situations involving numbers and apostrophes do not get inadvertently changed.

Fixes #13
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support year abbreviations
2 participants
@sapegin @groenroos