feat!: remove feature gates — adaptive/trust/placement always compiled by dirvine · Pull Request #20 · saorsa-labs/saorsa-core

dirvine · 2026-02-07T09:55:25Z

Summary

Remove 9 feature flags: adaptive-ml, trust-routing, geographic, sybil-detection, collusion-detection, skademlia, placement, experimental, full
Always compile all adaptive networking, trust-weighted routing, placement orchestration, and geographic modules
Bump version 0.10.5 → 0.11.0 (breaking change)
Unblock 21 integration tests that were silently skipped in default CI runs
Fix benchmark compilation (saorsa_core::adaptive now always available)
Delete fallback no-op implementations in core_engine.rs and dht_network_manager.rs
New test: adaptive_always_available_test.rs — 6 tests proving all modules compile under default features

Retained features

default = ["metrics"], metrics, mocks, h2_greedy, test-utils

Files changed (32)

Cargo.toml — feature definitions + examples
7 src/ files — cfg gate removal + fallback deletion
20 tests/ files — crate-level cfg removal
3 .github/workflows/ — CI flag cleanup
1 new test file

Test plan

🤖 Generated with Claude Code

BREAKING: Remove adaptive-ml, trust-routing, geographic, sybil-detection, collusion-detection, skademlia, placement, experimental, and full features. All adaptive networking, trust-weighted routing, placement orchestration, and geographic modules are now always compiled. This eliminates 21 silently skipped integration tests in default CI, fixes benchmark compilation, and removes unnecessary complexity from no-op fallback implementations. Only the `metrics` feature (optional dep on prometheus) remains gated. Features retained: default, metrics, mocks, h2_greedy, test-utils. Changes: - Cargo.toml: remove 9 features, bump 0.10.5 → 0.11.0 - 7 src/ files: remove all #[cfg(feature = "...")] gates + delete fallback implementations in core_engine.rs and dht_network_manager.rs - 20 test files: remove #![cfg(feature = "adaptive-ml")] - 3 CI workflows: remove adaptive-ml from --features flags - New test: adaptive_always_available_test.rs (6 compile+runtime checks) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

Removes feature-gating around adaptive/trust/geographic/placement functionality so these modules always compile, and updates CI/tests/docs config accordingly.

Changes:

Deleted cfg(feature = "...") gates from core modules and integration tests to ensure modules are always available.
Updated CI workflows to stop enabling the removed feature flags when building/running integration tests.
Added a new integration test ensuring adaptive/placement/geographic APIs remain available under default features.

Reviewed changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
Cargo.toml	Removes deprecated feature definitions; bumps version; updates docs.rs and example requirements.
src/lib.rs	Makes adaptive/geographic/placement modules and exports unconditional.
src/prelude.rs	Makes placement + adaptive prelude exports unconditional.
src/network.rs	Makes trust/EigenTrust integration always compiled and removes feature-gated APIs/docs.
src/error.rs	Makes AdaptiveNetworkError → P2PError conversion always compiled.
src/dht/mod.rs	Makes trust peer selector module + re-exports unconditional.
src/dht/core_engine.rs	Makes trust-weighted peer selection always compiled; removes non-adaptive fallback implementations.
src/dht_network_manager.rs	Removes feature-gated no-op stubs and always records trust outcomes.
tests/adaptive_always_available_test.rs	New test asserting core modules/types are available under default features.
tests/*	Removes `#![cfg(feature = "adaptive-ml")]` gating so tests run in default CI.
.github/workflows/integration-core.yml	Removes `adaptive-ml` from CI feature lists when building/running tests.
.github/workflows/integration-identity.yml	Removes `adaptive-ml` from CI feature lists when building/running tests.
.github/workflows/integration-network.yml	Removes `adaptive-ml` from CI feature lists when building/running tests.

Copilot · 2026-02-07T09:56:28Z

-      # adaptive-ml is required for these tests.
      - name: Build tests
-        run: cargo build --tests --features "default,adaptive-ml,mocks,h2_greedy,test-utils"
+        run: cargo build --tests --features "default,mocks,h2_greedy,test-utils"


default is not an enable-able Cargo feature name (it’s a special key), so --features "default,..." can cause Cargo to error with “feature default not found”. Drop default, from these lists (since default features are enabled implicitly), or if you intended to be explicit, use --no-default-features --features "metrics,mocks,h2_greedy,test-utils".

Copilot · 2026-02-07T09:56:29Z

+        run: cargo nextest run --test adaptive_components_test --features "default,mocks,h2_greedy,test-utils" --no-fail-fast

      - name: Adaptive Integration
-        run: cargo nextest run --test adaptive_integration_tests --features "default,adaptive-ml,mocks,h2_greedy,test-utils" --no-fail-fast
+        run: cargo nextest run --test adaptive_integration_tests --features "default,mocks,h2_greedy,test-utils" --no-fail-fast

      - name: Multi-Armed Bandit
-        run: cargo nextest run --test multi_armed_bandit_integration_test --features "default,adaptive-ml,mocks,h2_greedy,test-utils" --no-fail-fast
+        run: cargo nextest run --test multi_armed_bandit_integration_test --features "default,mocks,h2_greedy,test-utils" --no-fail-fast

      - name: Q-Learning Cache
-        run: cargo nextest run --test q_learning_cache_integration_test --features "default,adaptive-ml,mocks,h2_greedy,test-utils" --no-fail-fast
+        run: cargo nextest run --test q_learning_cache_integration_test --features "default,mocks,h2_greedy,test-utils" --no-fail-fast

      - name: Hyperbolic Routing
-        run: cargo nextest run --test hyperbolic_routing_test --features "default,adaptive-ml,mocks,h2_greedy,test-utils" --no-fail-fast
+        run: cargo nextest run --test hyperbolic_routing_test --features "default,mocks,h2_greedy,test-utils" --no-fail-fast


default is not an enable-able Cargo feature name (it’s a special key), so --features "default,..." can cause Cargo to error with “feature default not found”. Drop default, from these lists (since default features are enabled implicitly), or if you intended to be explicit, use --no-default-features --features "metrics,mocks,h2_greedy,test-utils".

Copilot · 2026-02-07T09:56:29Z

+        run: cargo build --tests --features "default,mocks,h2_greedy,test-utils" -j2

      - name: EigenTrust
-        run: cargo nextest run --test eigentrust_integration_test --features "default,adaptive-ml,mocks,h2_greedy,test-utils" --no-fail-fast
+        run: cargo nextest run --test eigentrust_integration_test --features "default,mocks,h2_greedy,test-utils" --no-fail-fast


Same issue as other workflows: default is not a Cargo feature you can list under --features. Remove default, (or switch to --no-default-features --features "metrics,..." if you intended an explicit set).

Copilot · 2026-02-07T09:56:29Z

+        run: cargo build --tests --features "default,mocks,h2_greedy,test-utils"

      - name: Gossipsub
-        run: cargo nextest run --test gossipsub_integration_test --features "default,adaptive-ml,mocks,h2_greedy,test-utils" --no-fail-fast
+        run: cargo nextest run --test gossipsub_integration_test --features "default,mocks,h2_greedy,test-utils" --no-fail-fast

      - name: Coordinator Integration
-        run: cargo nextest run --test coordinator_integration_test --features "default,adaptive-ml,mocks,h2_greedy,test-utils" --no-fail-fast
+        run: cargo nextest run --test coordinator_integration_test --features "default,mocks,h2_greedy,test-utils" --no-fail-fast


--features "default,... risks failing because default isn’t a normal feature. Remove it from the comma-separated feature list (or use --no-default-features --features "metrics,..." if you need explicitness).

Copilot · 2026-02-07T09:56:29Z

 [package.metadata.docs.rs]
-features = []
-no-default-features = true
+features = ["metrics"]


This docs.rs configuration is internally redundant: with no-default-features = false, docs.rs will already build with default = ["metrics"], and specifying features = ["metrics"] again doesn’t change anything. Consider either removing the features = ["metrics"] line (keep defaults), or setting no-default-features = true if the intent is “metrics only” regardless of future default changes.

Suggested change

features = ["metrics"]

Copilot · 2026-02-07T09:56:30Z

+    let _ = std::any::type_name::<GeographicNetworkConfig>();
+    assert!(!std::any::type_name::<GeographicNetworkConfig>().is_empty());


This calls type_name::<GeographicNetworkConfig>() twice; it’s a minor duplication. Consider storing it in a local variable once (or keeping just the assert!), which makes the intent clearer and avoids repeated calls.

Suggested change

let _ = std::any::type_name::<GeographicNetworkConfig>();

assert!(!std::any::type_name::<GeographicNetworkConfig>().is_empty());

let type_name = std::any::type_name::<GeographicNetworkConfig>();

assert!(!type_name.is_empty());

greptile-apps · 2026-02-07T09:58:39Z

Greptile Overview

Greptile Summary

This PR removes all feature gate complexity from the adaptive networking, trust routing, and placement systems by making these modules always available at compile time. The change eliminates 9 feature flags (adaptive-ml, trust-routing, geographic, sybil-detection, collusion-detection, skademlia, placement, experimental, full) and bumps the version to 0.11.0 as a breaking change.

Key Changes:

Removed #[cfg(feature)] conditional compilation gates from 7 source files in src/
Deleted fallback no-op implementations that were used when features were disabled
Removed #![cfg(feature)] from 20 integration test files, unblocking 21 tests that were silently skipped in default CI runs
Added tests/adaptive_always_available_test.rs with 6 tests proving modules compile under default features
Updated 3 CI workflow files to remove adaptive-ml from feature flag lists
Removed feature requirements from examples in Cargo.toml

Impact:

All adaptive networking, EigenTrust trust engine, placement orchestration, and geographic modules are now core functionality
Integration tests that validate these systems now run in CI by default
Examples (security_example, adaptive_network_monitor) no longer require feature flags
Binary size will increase for users who previously compiled without these features
Simplifies the API surface and reduces maintenance burden of feature flag combinations

Confidence Score: 5/5

This PR is safe to merge with minimal risk - it's a well-executed refactoring that simplifies the codebase by removing conditional compilation complexity
The changes are systematic and consistent across all affected files. The author has thoroughly tested the changes (all local checks passed per PR description) and added a new test file specifically to verify the changes work correctly. The PR removes complexity rather than adding it, which reduces the risk of bugs. All changes are purely about removing feature gates and making existing code unconditionally available - no new logic is introduced.
No files require special attention - all changes are consistent, well-structured, and follow the same pattern of removing feature gates

Important Files Changed

Filename	Overview
Cargo.toml	Removed 9 feature flags (`adaptive-ml`, `trust-routing`, `geographic`, `sybil-detection`, `collusion-detection`, `skademlia`, `placement`, `experimental`, `full`) and bumped version to 0.11.0; removed feature requirements from examples
src/dht/core_engine.rs	Removed `#[cfg(feature = "adaptive-ml")]` gates from trust-weighted peer selection methods and imports; deleted fallback no-op implementation
src/dht_network_manager.rs	Removed feature gates from `record_peer_success` and `record_peer_failure` methods; deleted no-op fallback implementations
src/network.rs	Removed feature gates from EigenTrust engine initialization and trust API methods; trust engine now always available
src/lib.rs	Updated module visibility - adaptive, placement, and geographic modules now unconditionally exported without feature gates
tests/adaptive_always_available_test.rs	New test file with 6 compile-time and runtime checks proving adaptive/placement/geographic modules are always available under default features
.github/workflows/integration-core.yml	Removed `adaptive-ml` from feature flags in build and test commands; tests now run with default features

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Cargo as Cargo.toml
    participant Src as Source Files
    participant Tests as Test Files
    participant CI as CI Workflows
    participant Build as Build System

    Dev->>Cargo: Remove 9 feature flags
    Note over Cargo: adaptive-ml, trust-routing,<br/>geographic, sybil-detection,<br/>collusion-detection, skademlia,<br/>placement, experimental, full
    
    Dev->>Cargo: Bump version 0.10.5 → 0.11.0
    Dev->>Cargo: Remove example feature requirements
    
    Dev->>Src: Remove #[cfg(feature)] gates
    Note over Src: src/dht/core_engine.rs<br/>src/dht_network_manager.rs<br/>src/network.rs<br/>src/lib.rs<br/>src/prelude.rs
    
    Dev->>Src: Delete fallback no-op implementations
    Note over Src: record_peer_success/failure<br/>trust selection methods
    
    Dev->>Tests: Remove #![cfg(feature)] from 20 test files
    Note over Tests: All adaptive/trust/placement<br/>tests now run by default
    
    Dev->>Tests: Add adaptive_always_available_test.rs
    Note over Tests: 6 compile-time + runtime checks
    
    Dev->>CI: Update workflow feature flags
    Note over CI: Remove adaptive-ml from<br/>all CI test commands
    
    Build->>Src: Compile adaptive modules
    Note over Build: Always compiled,<br/>no feature flag required
    
    Build->>Tests: Run all 21 integration tests
    Note over Tests: Previously skipped tests<br/>now execute in CI
    
    Tests-->>Build: All tests pass
    Build-->>Dev: Build successful

claude · 2026-02-07T09:58:42Z

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

- Remove invalid `default` from --features lists in CI workflows (default features are enabled implicitly by Cargo) - Remove redundant `features = ["metrics"]` from docs.rs config (already included via no-default-features = false) - Store type_name result in local variable to avoid duplicate call Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

grumbach

Nice one!

After rebasing onto main (which includes PR #20's feature gate removal), our new code still had #[cfg(feature = "adaptive-ml")] guards that referenced the now-removed feature, causing compilation failures in CI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings February 7, 2026 09:55

Copilot AI reviewed Feb 7, 2026

View reviewed changes

grumbach approved these changes Feb 9, 2026

View reviewed changes

grumbach merged commit 4a3ab10 into main Feb 9, 2026
19 checks passed

dirvine mentioned this pull request Feb 9, 2026

feat: DHT consumer error reporting and trust feedback #21

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: remove feature gates — adaptive/trust/placement always compiled#20

feat!: remove feature gates — adaptive/trust/placement always compiled#20
grumbach merged 2 commits intomainfrom
remove-feature-gates

dirvine commented Feb 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 7, 2026

Uh oh!

Copilot AI Feb 7, 2026

Uh oh!

Copilot AI Feb 7, 2026

Uh oh!

Copilot AI Feb 7, 2026

Uh oh!

Copilot AI Feb 7, 2026

Uh oh!

Copilot AI Feb 7, 2026

Uh oh!

greptile-apps bot commented Feb 7, 2026

Important Files Changed

Uh oh!

claude bot commented Feb 7, 2026

Uh oh!

grumbach left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		let _ = std::any::type_name::<GeographicNetworkConfig>();
		assert!(!std::any::type_name::<GeographicNetworkConfig>().is_empty());

Conversation

dirvine commented Feb 7, 2026

Summary

Retained features

Files changed (32)

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot commented Feb 7, 2026

Greptile Overview

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

claude bot commented Feb 7, 2026

Code review

Uh oh!

grumbach left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants