Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.7.0 Release Plan #90

Closed
32 tasks done
x87 opened this issue Nov 12, 2020 · 14 comments
Closed
32 tasks done

3.7.0 Release Plan #90

x87 opened this issue Nov 12, 2020 · 14 comments
Labels
Milestone

Comments

@x87
Copy link
Collaborator

x87 commented Nov 12, 2020

Features

Bug Fixes

  • Fixed an issue when label cannot be decompiled correctly The label cannot be decompiled correctly 2 #103
  • Fixed high-level code limitation High-level code limitation [BUG] #114
  • Model Id corrupted when duplicated in 2dfx section of IDE file Model Id corrupted when duplicated in 2dfx section of IDE file #120
  • In GTA3, VC, SA disassembler now always assume the label value is integer regardless of data type
  • Type of parameters in opcode 0237 in GTA3 changed back to a number, not model id (regression in 3.6.0)
  • Disassembler now correctly writes cleo_return word before the arguments of opcode 0AB2
  • Compilation error for class Actor.Create when argument for pedtype param is deprecated enum value ("extended param")
  • Fixed an issue when the gosub command was disassembled into a function even with "Write opcodes" enabled
  • Fixed an issue when a subroutine (e.g. MyLabel()) can not be compiled in GTA SA SCR mode (reported here)

Breaking Changes

  • constants.txt in edit modes are converted from a dictionary to the source file implicitly included during compilation. On practice it should not affect users but if you are using modified constants.txt you will need to wrap the content of this file in const..end:

Before 3.7.0

false=0
true=1
TIMERA=32@
TIMERB=33@

After 3.7.0

const
false=0
true=1
TIMERA=32@
TIMERB=33@
end
  • Variable @sb:\ used in modes.xml has been replaced with @sb: to better handle cases where the trailing slash is not needed.
@x87
Copy link
Collaborator Author

x87 commented Jan 1, 2021

v3.7.0-alpha.0 is available for preview:
https://github.com/sannybuilder/dev/releases

By no means this is feature complete and it doesn't include all planned changes. But this is the way for me to get early feedback and fine-tune things before the release. Please comment 👍

@x87
Copy link
Collaborator Author

x87 commented Jan 2, 2021

Observation 1: changing constants.txt to an implicit include file broke the SCM file header compilation. Compiler expects DEFINE lines to be the very first.
Observation 2: alpha version string is too long to fit into 24 characters limit for the object 0.

Fixed in v3.7.0-alpha.1

@XMDS
Copy link

XMDS commented Jan 8, 2021

@x87 Currently switching from other modes to VC Mobile mode, there will be a delayed unresponsive state, wait for a period of time to switch to this mode normally, and use this mode to create new text and write cleo, there will still be unresponsive delays. In addition. You seem to forget to add the gxt file of VCM.

There should be a bug. In the SB setting, the label format setting and the case conversion setting seem to be unable to coexist. When setting either case conversion, we will not be able to choose to set the label format. You can take a look

@XMDS
Copy link

XMDS commented Jan 8, 2021

@x87 2 suggestions:

  1. We should set the "write opcodes" setting to open by default , so that the player can correctly display the standard OP description syntax when decompiling

  2. Gosub still displays the abbreviated label () when "write opcodes" is decompiled. This problem has been reported by many people.

@x87
Copy link
Collaborator Author

x87 commented Jan 8, 2021

You seem to forget to add the gxt file of VCM.

there was no GXT file in sannybuilder/data#11 which I just merged as is. I don't think I have this file. If you can open another PR with this file I'm happy to add that in.

When setting either case conversion, we will not be able to choose to set the label format.

great catch! I will look into it

@x87
Copy link
Collaborator Author

x87 commented Jan 8, 2021

switching from other modes to VC Mobile mode, there will be a delayed unresponsive state,

I noticed that too. I think it happens as Sanny scans ide files to get a list of models for autocomplete. If we had one single file with all models it would load much faster.

@XMDS
Copy link

XMDS commented Jan 8, 2021

You seem to forget to add the gxt file of VCM.

there was no GXT file in sannybuilder/data#11 which I just merged as is. I don't think I have this file. If you can open another PR with this file I'm happy to add that in.

In this branch, in my second reply, there is a zip file download. Although it is an old file, it contains a gxt file, which you can add to the sb directory. In addition, it also has two different sizes of icons for the VC mobile version, which you can use as icons for sb's VCM mode

sannybuilder/data#11

@sannybuilder sannybuilder deleted a comment from XMDS Jan 8, 2021
@sannybuilder sannybuilder deleted a comment from XMDS Jan 8, 2021
@XMDS
Copy link

XMDS commented Jan 8, 2021

@x87
Copy link
Collaborator Author

x87 commented Jan 8, 2021

Yes I downloaded it, thanks. Just removed those comments as they don't seem relevant.

@x87
Copy link
Collaborator Author

x87 commented Jan 15, 2021

forget to add the gxt file of VCM.

In the SB setting, the label format setting and the case conversion setting seem to be unable to coexist.

Gosub still displays the abbreviated label () when "write opcodes" is decompiled. This problem has been reported by many people.

fixed in alpha.4
https://github.com/sannybuilder/dev/releases/download/v3.7.0-alpha.4/SannyBuilder-v3.7.0-alpha.4.exe

@x87
Copy link
Collaborator Author

x87 commented Jan 24, 2021

Currently switching from other modes to VC Mobile mode, there will be a delayed unresponsive state

this has been addressed in beta.0:
https://github.com/sannybuilder/dev/releases/tag/v3.7.0-beta.0

Download: https://github.com/sannybuilder/dev/releases/download/v3.7.0-beta.0/SannyBuilder-v3.7.0-beta.0.exe

@XMDS
Copy link

XMDS commented Jan 25, 2021

@x87 Constant highlighting is no longer valid in beta0.0 version

@x87
Copy link
Collaborator Author

x87 commented Jan 25, 2021

@XMDS thank you for reporting. not sure how I missed this.

here is the fix: place attached core.dll to Sanny Builder\lib folder.
core.dll.zip

@x87 x87 closed this as completed Jan 31, 2021
@x87 x87 unpinned this issue Feb 2, 2021
@x87 x87 added the roadmap label Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants