Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix focus input when mask changes #154

Merged
merged 1 commit into from
Sep 1, 2018
Merged

Fix focus input when mask changes #154

merged 1 commit into from
Sep 1, 2018

Conversation

ngryman
Copy link
Contributor

@ngryman ngryman commented Aug 24, 2018

Replaces #153.

@ngryman ngryman mentioned this pull request Aug 24, 2018
Closed
@sanniassin sanniassin merged commit 46e78f5 into sanniassin:master Sep 1, 2018
@sanniassin
Copy link
Owner

Thanks a lot. Will release an update soon.

sanniassin added a commit that referenced this pull request Sep 1, 2018
@sanniassin
Comment for #154
38fa04b
@sanniassin
Copy link
Owner

@ngryman Released 2.0.4

@ngryman ngryman deleted the fix/focus branch September 4, 2018 10:35
@ngryman ngryman restored the fix/focus branch September 4, 2018 10:35
@myagkou
Copy link

myagkou commented Jan 18, 2021 •
edited
Loading

This is an incomplete fix because of a deferred input selection update.
https://github.com/sanniassin/react-input-mask/blob/2.0.4/src/index.js#L279

There would be the same reported behaviour if I have changed focus to a field before deferred code works.

@myagkou
Copy link

myagkou commented Jan 18, 2021

I may provide a PR fixing the issue but I see the current codebase is far ahead of the v2.0.4 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ngryman @sanniassin @myagkou