Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitignore #14

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add gitignore #14

wants to merge 3 commits into from

Conversation

thodson-usgs
Copy link
Contributor

My collaborators had a tendency to accidentally commit PDF, which made it harder to incorporate their pull requests.
Consider adding PDF to gitignore.

@sanjib-sen
Copy link
Owner

sanjib-sen commented Jun 1, 2023

Good observation. Thanks. Although, I am not sure what will happen when a person not so good with gitignore suddenly finds that their PDFs are not updating after git sync! (Considering many people also commit their PDF's).

@thodson-usgs
Copy link
Contributor Author

I'm okay making it (slightly) harder to commit a pdf, but that's up to you.
Then perhaps ignore everything in PDF except the pdf's with

PDF/*
!PDF/*.pdf

@thodson-usgs
Copy link
Contributor Author

thodson-usgs commented Jun 1, 2023

My justification being that git stores the entire file for each commit---not a diff--- so a careless user will commit numerous pdfs during the lifecycle of a document, bloating the repo. But I also recognize the convenience of having the pdf accessible via github.

Copy link

@ahmadrashdy ahmadrashdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants