Forms spacing when outside form builder #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand the title of this PR. Looks like it includes a lot of non-relevant commits? |
| import React from 'react' | ||
| import styles from 'part:@sanity/components/buttons/collection-style' | ||
|
|
||
| export default class ButtonsCollection extends React.PureComponent { |
There was a problem hiding this comment.
Idiomatically, should perhaps be named with singular button – as in ButtonCollection
There was a problem hiding this comment.
This belongs to #824
kristofferjs
force-pushed
the
forms-spacing-when-outside-form-builder
branch
from
4302bf2
to
68bf726
Compare
bjoerge
pushed a commit
that referenced
this pull request
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds spaces between formfields and fieldsets when used outside form-builder.