Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): remove timeout and retry from releases store #7866

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

pedrobonamin
Copy link
Contributor

Description

Removes the timeout and retry function from the observable, given they are not needed and was causing issues by creating new listeners every 10 seconds.

Retry is not needed here given is already included in the listener.

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner November 22, 2024 15:14
@pedrobonamin pedrobonamin requested review from bjoerge and removed request for a team November 22, 2024 15:14
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 3:22pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 3:22pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 3:22pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 3:22pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Nov 22, 2024 3:22pm

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Nov 22, 2024 3:25 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 5s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 41s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 46s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 44s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 41s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 54s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Fri, 22 Nov 2024 15:26:51 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 14.5 efps (69ms) 11.8 efps (85ms) +16ms (+23.2%) 🔴
article (body) 45.9 efps (22ms) 50.3 efps (20ms) -2ms (-8.7%)
article (string inside object) 15.9 efps (63ms) 12.3 efps (82ms) +19ms (+29.4%) 🔴
article (string inside array) 13.7 efps (73ms) 10.2 efps (98ms) +25ms (+34.2%) 🔴
recipe (name) 29.4 efps (34ms) 20.4 efps (49ms) +15ms (+44.1%) 🔴
recipe (description) 32.3 efps (31ms) 21.7 efps (46ms) +15ms (+48.4%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 14.6 efps (69ms) 5.9 efps (171ms) +102ms (+148.9%) 🔴
synthetic (string inside object) 15.5 efps (65ms) 6.3 efps (158ms) +94ms (+145.0%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 69ms 74ms 76ms 343ms 783ms 15.4s
article (body) 22ms 32ms 104ms 327ms 610ms 7.5s
article (string inside object) 63ms 69ms 87ms 300ms 634ms 9.7s
article (string inside array) 73ms 78ms 84ms 297ms 1335ms 10.3s
recipe (name) 34ms 37ms 56ms 76ms 14ms 11.4s
recipe (description) 31ms 32ms 37ms 130ms 0ms 6.3s
recipe (instructions) 6ms 8ms 9ms 10ms 0ms 3.3s
synthetic (title) 69ms 73ms 84ms 372ms 1584ms 15.2s
synthetic (string inside object) 65ms 67ms 75ms 615ms 1017ms 9.9s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 85ms 91ms 96ms 483ms 3174ms 18.3s
article (body) 20ms 24ms 38ms 308ms 769ms 7.3s
article (string inside object) 82ms 87ms 95ms 294ms 2756ms 11.7s
article (string inside array) 98ms 105ms 114ms 428ms 3991ms 13.4s
recipe (name) 49ms 51ms 56ms 95ms 849ms 11.1s
recipe (description) 46ms 49ms 61ms 132ms 709ms 7.8s
recipe (instructions) 6ms 9ms 9ms 25ms 0ms 3.3s
synthetic (title) 171ms 184ms 195ms 824ms 9225ms 26.2s
synthetic (string inside object) 158ms 166ms 183ms 971ms 8961ms 20.7s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@pedrobonamin pedrobonamin merged commit 41a63c8 into corel Nov 22, 2024
57 checks passed
@pedrobonamin pedrobonamin deleted the corel-remove-listener-retry branch November 22, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants