Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: resolving mismatch on snapshot for updated slugValidator #7855

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

jordanl17
Copy link
Member

Description

Applies this update to the associated testing suite

What to review

Testing

Notes for release

N/A

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 4:27am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 4:27am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 4:27am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 4:27am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2024 4:27am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Component Testing Report Updated Nov 21, 2024 4:28 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 41s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 9s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 36s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 45s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 39s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 56s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Nov 21, 2024

⚡️ Editor Performance Report

Updated Thu, 21 Nov 2024 04:30:41 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 16.1 efps (62ms) 11.9 efps (84ms) +22ms (+35.5%) 🔴
article (body) 53.3 efps (19ms) 56.5 efps (18ms) -1ms (-5.6%)
article (string inside object) 16.8 efps (60ms) 12.7 efps (79ms) +20ms (+32.8%) 🔴
article (string inside array) 14.9 efps (67ms) 10.9 efps (92ms) +25ms (+37.3%) 🔴
recipe (name) 31.3 efps (32ms) 20.8 efps (48ms) +16ms (+50.0%) 🔴
recipe (description) 34.5 efps (29ms) 22.2 efps (45ms) +16ms (+55.2%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 14.4 efps (70ms) 5.7 efps (175ms) +106ms (+151.8%) 🔴
synthetic (string inside object) 14.4 efps (70ms) 6.1 efps (163ms) +94ms (+134.5%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 62ms 66ms 74ms 167ms 527ms 15.3s
article (body) 19ms 22ms 40ms 248ms 378ms 6.3s
article (string inside object) 60ms 61ms 67ms 223ms 533ms 9.0s
article (string inside array) 67ms 72ms 79ms 321ms 1004ms 9.7s
recipe (name) 32ms 35ms 56ms 69ms 2ms 8.4s
recipe (description) 29ms 31ms 32ms 59ms 0ms 5.7s
recipe (instructions) 6ms 8ms 8ms 9ms 0ms 3.2s
synthetic (title) 70ms 74ms 79ms 424ms 1688ms 15.8s
synthetic (string inside object) 70ms 73ms 82ms 342ms 1469ms 10.1s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 84ms 91ms 153ms 374ms 3107ms 17.4s
article (body) 18ms 21ms 26ms 108ms 608ms 6.8s
article (string inside object) 79ms 83ms 94ms 208ms 2936ms 11.8s
article (string inside array) 92ms 99ms 107ms 273ms 3549ms 12.7s
recipe (name) 48ms 52ms 71ms 124ms 800ms 10.8s
recipe (description) 45ms 48ms 52ms 93ms 625ms 7.7s
recipe (instructions) 6ms 8ms 9ms 34ms 23ms 3.5s
synthetic (title) 175ms 188ms 370ms 906ms 10891ms 28.9s
synthetic (string inside object) 163ms 172ms 182ms 917ms 9015ms 20.2s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@pedrobonamin
Copy link
Contributor

Thanks Jordan!

@pedrobonamin pedrobonamin merged commit a3dc693 into corel Nov 21, 2024
58 checks passed
@pedrobonamin pedrobonamin deleted the corel-infer-test-fix branch November 21, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants