Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sanity): update and re-write unit tests (CreateReleaseDialog/useVersionOperations) #7853

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

RitaDias
Copy link
Contributor

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 8:38am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 8:38am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 8:38am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 8:38am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2024 8:38am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Component Testing Report Updated Nov 21, 2024 8:38 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 40s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 52s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 34s 1 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 37s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 44s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 39s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 55s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Nov 20, 2024

⚡️ Editor Performance Report

Updated Thu, 21 Nov 2024 08:40:50 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 16.7 efps (60ms) 13.0 efps (77ms) +17ms (+28.3%) 🔴
article (body) 59.7 efps (17ms) 61.7 efps (16ms) -1ms (-3.3%)
article (string inside object) 18.9 efps (53ms) 13.7 efps (73ms) +20ms (+37.7%) 🔴
article (string inside array) 15.6 efps (64ms) 11.6 efps (86ms) +22ms (+34.4%) 🔴
recipe (name) 30.8 efps (33ms) 20.4 efps (49ms) +17ms (+50.8%) 🔴
recipe (description) 34.5 efps (29ms) 21.3 efps (47ms) +18ms (+62.1%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 14.7 efps (68ms) 6.0 efps (168ms) +100ms (+146.3%) 🔴
synthetic (string inside object) 15.5 efps (65ms) 6.5 efps (155ms) +91ms (+140.3%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 60ms 68ms 76ms 252ms 714ms 13.8s
article (body) 17ms 19ms 23ms 128ms 278ms 5.8s
article (string inside object) 53ms 57ms 63ms 203ms 262ms 8.6s
article (string inside array) 64ms 66ms 72ms 242ms 826ms 9.2s
recipe (name) 33ms 34ms 38ms 71ms 0ms 8.9s
recipe (description) 29ms 32ms 33ms 57ms 0ms 5.9s
recipe (instructions) 6ms 8ms 9ms 22ms 0ms 3.3s
synthetic (title) 68ms 73ms 80ms 152ms 1216ms 16.5s
synthetic (string inside object) 65ms 68ms 78ms 574ms 1634ms 10.2s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 77ms 81ms 162ms 368ms 2715ms 16.5s
article (body) 16ms 19ms 26ms 286ms 555ms 6.2s
article (string inside object) 73ms 78ms 88ms 358ms 2512ms 11.4s
article (string inside array) 86ms 93ms 103ms 330ms 3118ms 12.1s
recipe (name) 49ms 52ms 60ms 100ms 881ms 11.1s
recipe (description) 47ms 49ms 74ms 105ms 681ms 8.0s
recipe (instructions) 6ms 8ms 9ms 10ms 0ms 3.2s
synthetic (title) 168ms 177ms 186ms 597ms 8888ms 26.3s
synthetic (string inside object) 155ms 160ms 169ms 975ms 8363ms 18.7s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@RitaDias RitaDias force-pushed the update-tests-rita branch 2 times, most recently from 128590e to 3a83377 Compare November 20, 2024 14:18
@RitaDias RitaDias changed the title test(sanity): update and re-write unit tests test(sanity): update and re-write unit tests (CreateReleaseDialog/useVersionOperations) Nov 21, 2024
@RitaDias RitaDias marked this pull request as ready for review November 21, 2024 08:57
@RitaDias RitaDias requested a review from a team as a code owner November 21, 2024 08:57
@RitaDias RitaDias requested review from rexxars and removed request for a team November 21, 2024 08:57
@RitaDias RitaDias merged commit dbdee62 into corel Nov 21, 2024
59 checks passed
@RitaDias RitaDias deleted the update-tests-rita branch November 21, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant