fix: create integration copy + layout updates #7787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
robinpyon
commented
Nov 11, 2024
| @@ -61,9 +61,7 @@ export function CreateLinkedDocumentBannerContent(props: CreateLinkedDocumentBan | |||
| </Flex> | |||
| <Stack space={4}> | |||
| <Heading size={2}>{t('create-link-info-popover.header')}</Heading> | |||
| <Text size={1}> | |||
| <Translate t={t} i18nKey={'create-link-info-popover.text'} /> | |||
There was a problem hiding this comment.
No longer using the Translate component as the create-link-info-popover.text resource no longer contains markup
|
No changes to documentation |
robinpyon
commented
Nov 11, 2024
| @@ -96,7 +96,8 @@ export function CreateLinkedDocumentBannerContent(props: CreateLinkedDocumentBan | |||
| icon={InfoOutlineIcon} | |||
| mode="bleed" | |||
| onClick={toggleOpen} | |||
| style={{marginBottom: '-1em', marginTop: '-1em'}} | |||
| // Negative margins added to prevent the button from blowing out banner height | |||
| style={{marginBottom: '-0.5em', marginTop: '-0.5em'}} | |||
There was a problem hiding this comment.
Incredibly minor tweak which just ensures the button is the correct size on hover.
robinpyon
commented
Nov 11, 2024
Comment on lines
-44
to
-57
|
|
||
| <Flex flex={1} justify="flex-end" gap={2}> | ||
| <Button | ||
| mode="bleed" | ||
| text={t('unlink-from-create-dialog.cancel.text')} | ||
| onClick={onClose} | ||
| /> | ||
| <Button | ||
| tone="primary" | ||
| text={t('unlink-from-create-dialog.unlink.text')} | ||
| onClick={unlink} | ||
| disabled={unlinking} | ||
| /> | ||
| </Flex> |
There was a problem hiding this comment.
We now defer layout rendering to the component itself
robinpyon
commented
Nov 11, 2024
| <StartInCreateDialog | ||
| content: <StartInCreateActionContent />, | ||
| footer: ( | ||
| <StartInCreateActionFooter |
There was a problem hiding this comment.
Similarly, we separate document action content and footer to ensure it renders a little more closely to what you see in the studio elsewhere
robinpyon
commented
Nov 11, 2024
packages/sanity/src/core/form/inputs/PortableText/object/BlockObject.tsx
Show resolved
Hide resolved
robinpyon
commented
Nov 11, 2024
There was a problem hiding this comment.
Similar to above, these Create specific data attrs are no longer needed
|
Component Testing Report Updated Nov 11, 2024 10:37 AM (UTC) ✅ All Tests Passed -- expand for details
|
⚡️ Editor Performance ReportUpdated Mon, 11 Nov 2024 10:43:09 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
RitaDias
approved these changes
Nov 11, 2024
bjoerge
added a commit
that referenced
this pull request
Nov 11, 2024
* next: fix: create integration copy + layout updates (#7787)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces some very minor copy and layout updates to the existing Studio → Create integration. All changes are purely cosmetic.
What to review
footerprop (as opposed to rendering these within the dialog body)Testing
N/A – copy and minor layout tweaks only
Notes for release
Not required