Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(sanity): update label onUncaughtError from internal to beta #7612

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

RitaDias
Copy link
Contributor

Description

Mistakenly a property in Source was tagged as internal when it should have been beta.
This impacts the docs

@RitaDias RitaDias requested a review from a team as a code owner October 14, 2024 07:12
@RitaDias RitaDias requested review from binoy14 and removed request for a team October 14, 2024 07:12
Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 7:23am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 7:23am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 7:23am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 7:23am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 7:23am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Oct 14, 2024 7:23am

@RitaDias RitaDias requested review from a team and jordanl17 October 14, 2024 07:12
@RitaDias RitaDias marked this pull request as draft October 14, 2024 07:13
Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Oct 14, 2024 7:19 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 32s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 38s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 47s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 15s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 26s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 36s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Mon, 14 Oct 2024 07:31:44 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 16.9 efps (59ms) 17.9 efps (56ms) -3ms (-5.1%)
article (body) 56.5 efps (18ms) 56.2 efps (18ms) +0ms (+0.6%)
article (string inside object) 18.2 efps (55ms) 17.9 efps (56ms) +1ms (+1.8%)
article (string inside array) 14.5 efps (69ms) 14.3 efps (70ms) +1ms (+1.4%)
recipe (name) 30.3 efps (33ms) 30.3 efps (33ms) +0ms (-/-%)
recipe (description) 34.5 efps (29ms) 34.5 efps (29ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (7ms) 99.9+ efps (6ms) -1ms (-/-%)
synthetic (title) 15.4 efps (65ms) 15.3 efps (66ms) +1ms (+0.8%)
synthetic (string inside object) 15.9 efps (63ms) 15.9 efps (63ms) +0ms (-/-%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 59ms 68ms 78ms 307ms 1558ms 14.9s
article (body) 18ms 21ms 49ms 126ms 341ms 6.1s
article (string inside object) 55ms 60ms 68ms 277ms 1223ms 9.2s
article (string inside array) 69ms 75ms 79ms 331ms 1961ms 10.3s
recipe (name) 33ms 38ms 42ms 72ms 58ms 9.5s
recipe (description) 29ms 32ms 43ms 93ms 52ms 6.4s
recipe (instructions) 7ms 9ms 10ms 33ms 0ms 3.4s
synthetic (title) 65ms 72ms 78ms 111ms 1747ms 14.8s
synthetic (string inside object) 63ms 67ms 77ms 167ms 2108ms 10.1s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 56ms 60ms 75ms 248ms 1291ms 13.5s
article (body) 18ms 20ms 27ms 120ms 124ms 6.0s
article (string inside object) 56ms 61ms 75ms 138ms 1085ms 9.4s
article (string inside array) 70ms 73ms 83ms 203ms 1798ms 10.1s
recipe (name) 33ms 37ms 42ms 67ms 59ms 9.3s
recipe (description) 29ms 32ms 36ms 130ms 50ms 6.5s
recipe (instructions) 6ms 9ms 9ms 10ms 0ms 3.2s
synthetic (title) 66ms 70ms 87ms 258ms 2238ms 16.6s
synthetic (string inside object) 63ms 68ms 76ms 480ms 2230ms 10.0s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@RitaDias RitaDias marked this pull request as ready for review October 14, 2024 11:12
@RitaDias RitaDias added this pull request to the merge queue Oct 14, 2024
Merged via the queue into next with commit 5b3ddc6 Oct 14, 2024
63 checks passed
@RitaDias RitaDias deleted the update-docs-for-property branch October 14, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants