[form-builder] Refactor DateTimeInput and add DateInput #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomax
approved these changes
Apr 25, 2018
Good point. That could probably be solved by replacing it with the default string input component, or? |
Absolutely! |
bjoerge
added a commit
that referenced
this pull request
Apr 27, 2018
bjoerge
added a commit
that referenced
this pull request
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor of the DateTimeInput, and also adds a default DateInput for
type: 'date'(this stores dates on theYYYY-MM-DDformat, ignoring the time part).I've basically moved the current DateTimeInput to a
BaseDateTimeInputand made it possible to disable the time part of the datetime string with theonlyDateprop.The
DateTimeInputandDateInputwraps theBaseDateTimeInput, and passes down the relevant props.This also includes a few consistency fixes and code cleanup (naming, unused code, etc).