Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): document store cache memo not working #7530

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

pedrobonamin
Copy link
Contributor

@pedrobonamin pedrobonamin commented Sep 20, 2024

Description

The document store cache was never found so each time we try to access it is creating a new store.
This is because the dependencies used in the cache were not the same in the set and get.

This PR fixes that.

What to review

Is there any possible side effect of utilizing the memoized store?

Testing

Existing tests should cover this .

Notes for release

@pedrobonamin pedrobonamin requested review from a team as code owners September 20, 2024 06:52
@pedrobonamin pedrobonamin requested review from ryanbonial and removed request for a team September 20, 2024 06:52
Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 7:02am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 7:02am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 7:02am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 7:02am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 7:02am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Sep 20, 2024 7:02am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Sep 20, 2024 7:05 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 43s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 36s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 33s 1 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 42s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 15s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 8s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 26s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 35s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, great find! Thanks Pedro!

@pedrobonamin pedrobonamin added this pull request to the merge queue Sep 23, 2024
Merged via the queue into next with commit 8c677c2 Sep 23, 2024
42 checks passed
@pedrobonamin pedrobonamin deleted the document-store-memo branch September 23, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants