-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next.js specific defaults for new projects #7465
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimeonGriggs
requested review from
cngonzalez
and removed request for
a team
September 4, 2024 10:22
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
Component Testing Report Updated Sep 4, 2024 10:35 AM (UTC) ✅ All Tests Passed -- expand for details
|
bjoerge
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running
sanity init
inside a Next.js project, this will:.env
file (if created) to.env.local
as this is what Next.js.gitignore
targetshttp://localhost:3000
so that the user isn't prompted to do so the first time they open the StudioWhat to review
I would've thought there'd be somewhere else in the codebase where this check-first-then-add-CORS logic would already exist, but couldn't find it, so recreated it.
Testing
Create a new Next.js project
Within it, run the below (but obviously targeting your local build)
Notes for release
sanity init
is run inside a Next.js project, an appropriate CORS origin is added to the projectsanity init
is run inside a Next.js project, environment variables are written to an.env.local
file