Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core, structure): validation on references #7431

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

jordanl17
Copy link
Member

@jordanl17 jordanl17 commented Aug 29, 2024

Description

It refactors document-store pair validation function by abstracting the part of that function that takes care of validating the document from the fetcher.
The document-store pair uses the document-store to fetch the document, which makes it not scalable enough for the releases use case, by dividing the validation from the fetcher, we could provide a document to the function validateDocumentWithReferences and this function will be responsible only for the document validation.

What to review

Testing

Existing tests are enough to cover this refactor packages/sanity/src/core/store/_legacy/document/document-pair/validation.test.ts

Notes for release

n/a, it's a refactor, functionality remains the same

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 2:06pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 2:06pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 2:06pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 2:06pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 2:06pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 2:06pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Aug 29, 2024

Component Testing Report Updated Sep 3, 2024 2:11 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 47s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 37s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 43s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 47s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 14s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 8s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 26s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 34s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

@pedrobonamin pedrobonamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @jordanl17

@jordanl17 jordanl17 added this pull request to the merge queue Sep 9, 2024
Merged via the queue into next with commit 112df24 Sep 9, 2024
42 checks passed
@jordanl17 jordanl17 deleted the chore/corel-references-validation branch September 9, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants