chore: support for sticky params in URL and intent ops #7429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Aug 30, 2024 2:33 PM (UTC) ✅ All Tests Passed -- expand for details
|
jordanl17
changed the title
jordanl17
commented
Aug 29, 2024
| ) | ||
|
|
||
| return <RouterContext.Provider value={router}>{props.children}</RouterContext.Provider> | ||
| } | ||
| const STICKY: string[] = [] |
There was a problem hiding this comment.
Currently there are no sticky params defined, however in content releases, the perspective key will be added here (the first current use of sticky params), but they can be used in other instances also
jordanl17
requested review from
bjoerge,
juice49,
cngonzalez,
binoy14,
RitaDias and
ricokahler
|
@RitaDias @jordanl17 we have some test coverage for this behaviour in We can't test this behaviour manually or automatically while Any objections to making |
jordanl17
commented
Aug 30, 2024
| @@ -30,4 +31,68 @@ describe('IntentLink', () => { | |||
| '/test/intent/edit/id=document-id-123;type=document-type/?perspective=bundle.summer-drop', | |||
| ) | |||
| }) | |||
|
|
|||
| it('should preserve sticky parameters when resolving intent link', () => { | |||
juice49
reviewed
Aug 30, 2024
| @@ -2,6 +2,7 @@ import {fromPairs, partition, toPairs} from 'lodash' | |||
| import {type ReactElement, type ReactNode, useCallback, useMemo} from 'react' | |||
| import {RouterContext} from 'sanity/_singletons' | |||
|
|
|||
| import {STICKY_PARAMS} from './stickyParams' | |||
juice49
approved these changes
Aug 30, 2024
pedrobonamin
approved these changes
Sep 2, 2024
jordanl17
added a commit
that referenced
this pull request
Sep 10, 2024
This reverts commit 8bc721b.
RitaDias
added a commit
that referenced
this pull request
Oct 4, 2024
…QueryResult (#7587) ### Description - Re-adds `QueryResult` interface - Changing the type in the collate to not explode when versions are present. When rebasing against `next` something went wrong specifically around this [PR](https://github.com/sanity-io/sanity/pull/7555/files). I wasn't able to fix it by using rebasing however this unblocks us and allows us to continue work. I imagine that the fix will likely be more around making sure that the collate prop type stayed the same (making the changes in the ENABLE_LRU_MEMO changes however I don't know the larger impact of making that change, so, for now I've set this up. Folks that are more knowledgeable around this should weight in before I merge since this is more like a temporary bandaid than a fix 🥲 Ash set up a branch `corel-pre-rebase-20241003` in case if you want to give the rebase another stab to avoid some of these issues. Keep in mind that you'll need to cherry pick [StickParams](#7429) commits as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ability to define sticky search params which will be retained state-fully in the URL throughout navigation
What to review
Primarily
packages/sanity/src/router/RouterProvider.tsxis where the handling and persistence of the params is handledTesting
Notes for release
N/A