Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output path when extracting schema #7414

Merged
merged 1 commit into from
Aug 23, 2024
Merged

output path when extracting schema #7414

merged 1 commit into from
Aug 23, 2024

Conversation

SimeonGriggs
Copy link
Contributor

Description

When running schema extract there's no feedback about what has happened, only that it succeeded or failed. I'd like it to be more descriptive and obvious, especially useful when modifying the output path.

What to review

I've only modified the .succeed call, but I see also these lines:

spinner.text = `Writing schema to ${path}`
    .start(
      enforceRequiredFields
        ? 'Extracting schema, with enforced required fields'
        : 'Extracting schema',
    )

But I've not seen them when I run schema extract, I only get the succeed call.

Testing

Does this need testing?

Notes for release

  • Output path to file when extracting schema

@SimeonGriggs SimeonGriggs requested a review from sgulseth August 23, 2024 09:58
@SimeonGriggs SimeonGriggs requested a review from a team as a code owner August 23, 2024 09:58
@SimeonGriggs SimeonGriggs requested review from cngonzalez and removed request for a team August 23, 2024 09:58
Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 10:07am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 10:07am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 10:07am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 10:07am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 10:07am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Aug 23, 2024 10:07am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Aug 23, 2024 10:12 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 42s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 30s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 37s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 43s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 45s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 14s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 26s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 15s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants