feat(cli): respect --no-auto-updates flag in CLI config
#7396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
cngonzalez
force-pushed
the
feat/sdx-1443/add-no-auto-updates
branch
from
27653a4
to
a332dd1
Compare
cngonzalez
changed the title
--no-auto-updates flag in CLI config--no-auto-updates flag in CLI config
|
Component Testing Report Updated Aug 20, 2024 8:22 PM (UTC) ✅ All Tests Passed -- expand for details
|
cngonzalez
force-pushed
the
feat/sdx-1443/add-no-auto-updates
branch
from
a332dd1
to
26dd321
Compare
binoy14
previously approved these changes
Aug 20, 2024
jordanl17
pushed a commit
that referenced
this pull request
Aug 29, 2024
* feat: respect no-auto-updates flag in cli config * test: add unit tests
This was referenced Sep 20, 2024
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As auto-updates become the new "default" way to build and deploy studios, we should ensure we're offering ways to easily override default behavior. This PR adds a helper function used in the build and deploy functions that prioritizes CLI flags first, then
sanity.cli.{ts|js}parameters, and then finally a default (which we can easily change).What to review
The new file -- does it belong in utils (it was a bit hard to place since it was shared by two different actions)?
Ways to test I may have missed? (see below)
Testing
This function is quite simple and goes through several layers of abstraction -- I'm not sure if it's particularly useful to test on its own. It would be ideal to test the
--no-auto-updatescommand line input, but I'm not sure it's possible. An integration test with the flags and a cliConfig context is also not particularly useful, because we have to mock the build action in our current tests.In lieu of that, please find a recording of the various options and configuration.
--no-auto-updates.flag.small.mov