fix(core): fix copy related issues #7394
Merged
+9
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes sdx-1591 Signed-off-by: Fred Carlsen <[email protected]>
Removes blur handler on reference preview. This is a unnecessary footgun, and it is triggered because focus will change to the first element in the opened reference pane. It isn’t clear why this only happens inside groups, though, so might dig more into that. Fixes #7265 Signed-off-by: Fred Carlsen <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Aug 20, 2024 12:46 PM (UTC) ✅ All Tests Passed -- expand for details
|
cngonzalez
pushed a commit
that referenced
this pull request
Aug 20, 2024
* fix(core): ignore all input/textarea elements when copying fixes sdx-1591 Signed-off-by: Fred Carlsen <[email protected]> * fix(core): fix blur issue for references inside groups Removes blur handler on reference preview. This is a unnecessary footgun, and it is triggered because focus will change to the first element in the opened reference pane. It isn’t clear why this only happens inside groups, though, so might dig more into that. Fixes #7265 Signed-off-by: Fred Carlsen <[email protected]> --------- Signed-off-by: Fred Carlsen <[email protected]>
|
This issue is still not fixed, see my comment on #7265 |
jordanl17
pushed a commit
that referenced
this pull request
Aug 29, 2024
* fix(core): ignore all input/textarea elements when copying fixes sdx-1591 Signed-off-by: Fred Carlsen <[email protected]> * fix(core): fix blur issue for references inside groups Removes blur handler on reference preview. This is a unnecessary footgun, and it is triggered because focus will change to the first element in the opened reference pane. It isn’t clear why this only happens inside groups, though, so might dig more into that. Fixes #7265 Signed-off-by: Fred Carlsen <[email protected]> --------- Signed-off-by: Fred Carlsen <[email protected]>
|
Still not fixed in 3.57.0 ... @sjelfull @jordanl17 |
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a few issues related to copy paste:
Referenced could not open when you had a reference field inside a field group and was not on the All fields tab. The fix here was to remove the
onBlurhandler. I'm not entirely sure why this breaks inside a group, since I could only reproduce in a newly installed studio and not inside the monorepo. Having a blur handler here is a footgun, and doesn't make sense given that we don't want to change the focused path until you click another field.Fixes #7265
It was also not possible to copy selected text in a textarea, since the Copy action was triggered and copied the full field content to the clipboard. Text areas should now be ignored.
What to review
Notes for release