Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): improvements to diff component styles and presentation #7385

Merged
merged 5 commits into from
Aug 29, 2024
Merged

chore(core): improvements to diff component styles and presentation #7385

merged 5 commits into from
Aug 29, 2024

Conversation

jordanl17
Copy link
Member

@jordanl17 jordanl17 commented Aug 19, 2024 •
edited
Loading

Description

A few minor improvements to conditional styling, and html 5 attributes around the diff components.

Most noticeably adding showFromValue which will be used in content releases work. This allows for control over whether the diff shows as changed from the initial value, or all as new

What to review

Testing

Notes for release

N/A

@vercel Vercel
Copy link

vercel bot commented Aug 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 1:30pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 1:30pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 1:30pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 1:30pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 1:30pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 1:30pm

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 19, 2024 •
edited
Loading

Component Testing Report Updated Aug 20, 2024 1:36 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 31s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 38s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 48s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 15s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 26s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 16s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 1m 53s 30 0 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 21s 3 0 0

@jordanl17 jordanl17 marked this pull request as ready for review August 20, 2024 15:46
@jordanl17 jordanl17 requested a review from a team as a code owner August 20, 2024 15:46
bjoerge
bjoerge reviewed Aug 20, 2024
View reviewed changes
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RitaDias
RitaDias reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too! Would want to have someone outside of the content releases to also have a look and give the final approval 🙏

pedrobonamin
pedrobonamin approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@pedrobonamin pedrobonamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving this changes, it looks good to me. Hope to get some eyes from @sanity-io/studio-dx on this.

bjoerge
bjoerge approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jordanl17 jordanl17 added this pull request to the merge queue Aug 29, 2024
Merged via the queue into next with commit 35b6600 Aug 29, 2024
42 checks passed
@jordanl17 jordanl17 deleted the corel-113-diff-components branch August 29, 2024 09:32
jordanl17 added a commit that referenced this pull request Aug 29, 2024
@jordanl17
chore(core): improvements to diff component styles and presentation (#…
9a05821 
…7385)

* chore(core): improvements to diff component styles and presentation

* chore(core): removing unused listener hook

* chore(core): tidying updates to reference search input observers

* chore(core): reverting changes to collation for reference search
This was referenced Sep 25, 2024
Open
Open
@samuelcastro samuelcastro mentioned this pull request Sep 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RitaDias RitaDias RitaDias left review comments

@pedrobonamin pedrobonamin pedrobonamin approved these changes

@bjoerge bjoerge bjoerge approved these changes

@juice49 juice49 Awaiting requested review from juice49

@cngonzalez cngonzalez Awaiting requested review from cngonzalez

@binoy14 binoy14 Awaiting requested review from binoy14

@ricokahler ricokahler Awaiting requested review from ricokahler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jordanl17 @bjoerge @RitaDias @pedrobonamin