Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infrastructure] Improve how we handle connection failures/reconnects #632

Merged
merged 6 commits into from
Mar 5, 2018

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Mar 2, 2018

This supersedes #626 as it relies on the old listener reconnect behavior.

This is a few adjustments regarding how we deal with connection errors (e.g. when the network is down, laptop lid is closed, etc.)

Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! LGTM!

@bjoerge bjoerge merged commit 582a5ee into next Mar 5, 2018
@bjoerge bjoerge deleted the improve-reconnecting branch March 5, 2018 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants