Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color input with unset fixes #584 #593

Merged
merged 3 commits into from
Feb 15, 2018
Merged

Color input with unset fixes #584 #593

merged 3 commits into from
Feb 15, 2018

Conversation

kristofferjs
Copy link
Contributor

No description provided.

bjoerge
bjoerge approved these changes Feb 15, 2018
View reviewed changes
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@kristofferjs kristofferjs merged commit f3cb00c into next Feb 15, 2018
@kristofferjs kristofferjs deleted the color-input-with-unset branch February 15, 2018 06:52
bjoerge pushed a commit that referenced this pull request Feb 15, 2018
@bjoerge
Color input with unset fixes #584 (#593)
a4c46a4 
* [color-input] Adding other values to schema

* [color-input] Support unset color (and unset as default)

* [color-input] Wider preview and other styles
bjoerge pushed a commit that referenced this pull request Feb 15, 2018
@bjoerge
Color input with unset fixes #584 (#593)
ab8cdfa 
* [color-input] Adding other values to schema

* [color-input] Support unset color (and unset as default)

* [color-input] Wider preview and other styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoerge bjoerge bjoerge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristofferjs @bjoerge