[imagetool] Make imagetool responsive #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
reviewed
Feb 14, 2018
| @@ -39,6 +40,7 @@ export default class HotspotImage extends React.PureComponent { | |||
| static defaultProps = { | |||
| alignX: 'center', | |||
| alignY: 'center', | |||
| className: undefined, | |||
There was a problem hiding this comment.
No need to specify undefined as default prop
There was a problem hiding this comment.
I get a warning from eslint if I don't.
| @@ -136,7 +138,7 @@ export default class HotspotImage extends React.PureComponent { | |||
| } | |||
| }) | |||
| return ( | |||
| <div className={className} style={style} ref={this.setContainerElement}> | |||
| <div className={className || styles.root} style={style} ref={this.setContainerElement}> | |||
There was a problem hiding this comment.
Shouldn't we merge the classNames? That's the pattern we use elsewhere I think.
| @@ -15,6 +16,41 @@ const MARGIN_PX = 8 | |||
| const CROP_HANDLE_SIZE = 12 | |||
| const HOTSPOT_HANDLE_SIZE = 10 | |||
|
|
|||
| function checkCropBounderies(value, delta) { | |||
There was a problem hiding this comment.
Typo bounderies should be boundaries (or just bounds for short)
| return true | ||
| } | ||
|
|
||
| function limitToBounderies(value, delta) { |
bjoerge
approved these changes
Feb 14, 2018
bjoerge
pushed a commit
that referenced
this pull request
Feb 15, 2018
* [form-builder] Styling imageToolInput * [imagetool] Make sure the container takes all width * [imgetool] Keep things inside boundries * [imagetool] Touch support * [imagetool] Canvas as block * [imagetool] CSS-file and wrapper. fix position bug * [form-builder] Not so high image tool input * [imagetool] Changes requested in PR * [imagetool] Typo
bjoerge
pushed a commit
that referenced
this pull request
Feb 15, 2018
* [form-builder] Styling imageToolInput * [imagetool] Make sure the container takes all width * [imgetool] Keep things inside boundries * [imagetool] Touch support * [imagetool] Canvas as block * [imagetool] CSS-file and wrapper. fix position bug * [form-builder] Not so high image tool input * [imagetool] Changes requested in PR * [imagetool] Typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bugs are still present: