[preview] Don't write ref attributes on materialized values #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexxars
approved these changes
Feb 7, 2018
| @@ -36,12 +36,16 @@ export default function createPathMaterializer(observeWithPaths) { | |||
|
|
|||
| const nextHeads = uniq(missingHeads.map(path => [path[0]])) | |||
|
|
|||
| const _isRef = isReference(value) | |||
There was a problem hiding this comment.
Why the underscore? I thought this was pretty much only used to mark private methods/properties in classes and similar?
There was a problem hiding this comment.
Just me being a scatterbrain. Originally called the variable _isReference due to conflict with the function name, then decided to shorten it. Fixed :)
bjoerge
force-pushed
the
preview-dont-set-ref-on-materialized-value
branch
from
f663036
to
3c0514a
Compare
kristofferjs
pushed a commit
that referenced
this pull request
Feb 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the preview was called with a value that was materialized, it was extending it afterwards with the original passed value. This caused the
_ref(and sometimes_key) attributes to be added to the resulting value, and could potentially cause subsequent calls with the same value to identify it as a reference and (needlessly) materialize it again.This patch omits writing the original attributes if the passed value was a reference.