Component/tri state switch #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexxars
requested changes
Feb 9, 2018
| @@ -32,13 +32,15 @@ export default class BooleanInput extends React.Component<Props> { | |||
| render() { | |||
| const {value, type, level, description, ...rest} = this.props | |||
|
|
|||
| console.log('boolean', value) | |||
bjoerge
requested changes
Feb 9, 2018
| @@ -36,6 +36,10 @@ | |||
| composes: root; | |||
| } | |||
|
|
|||
| .undefinedChecked { | |||
There was a problem hiding this comment.
Would it be better to call it .indeterminate?
| @@ -38,19 +38,29 @@ export default class Checkbox extends React.Component { | |||
|
|
|||
| setInput = el => { | |||
| this._input = el | |||
|
|
|||
| if (typeof value === 'undefined' && el) { | |||
There was a problem hiding this comment.
Could this be moved to componentDidMount instead? Personally that is the first place I'd look for it and expect it to be. And you don't have to worry about el (this._input) being null either.
kristofferjs
force-pushed
the
component/tri-state-switch
branch
from
73afc07
to
7b3e595
Compare
bjoerge
approved these changes
Feb 12, 2018
kristofferjs
pushed a commit
that referenced
this pull request
Feb 12, 2018
* [components] Tri state switch * [components] Support indeterminate state on checkboxes #47 * [components] Changes from PR
kristofferjs
pushed a commit
that referenced
this pull request
Feb 14, 2018
* [components] Tri state switch * [components] Support indeterminate state on checkboxes #47 * [components] Changes from PR
kristofferjs
pushed a commit
that referenced
this pull request
Feb 15, 2018
* [components] Tri state switch * [components] Support indeterminate state on checkboxes #47 * [components] Changes from PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows that a boolean is
undefined. Usually shows when creating a new document in studio.There is no support for setting the checkbox/switch back to
undefinedat this point.