Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] Make block text references to separate named types #572

Merged
merged 1 commit into from
Feb 5, 2018
Merged

[cli] Make block text references to separate named types #572

merged 1 commit into from
Feb 5, 2018

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Feb 5, 2018

This converts the different types of references into named types so the UI becomes clearer.

Before:
image

After:
image

rexxars
rexxars approved these changes Feb 5, 2018
View reviewed changes
Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bjoerge bjoerge merged commit 24ed5c1 into next Feb 5, 2018
@bjoerge bjoerge deleted the separate-block-reference-types-in-movies-template branch February 5, 2018 10:43
kristofferjs pushed a commit that referenced this pull request Feb 12, 2018
@bjoerge @kristofferjs
[cli] Make block text references to separate named types (#572)
dcaee03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rexxars rexxars rexxars approved these changes

@evenwestvang evenwestvang Awaiting requested review from evenwestvang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjoerge @rexxars