[imagetool] Scale down large images before passing to ImageTool #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
force-pushed
the
imagetool-resize-large-images
branch
from
ac824ca
to
a6c7f05
Compare
rexxars
requested changes
Feb 5, 2018
| import PropTypes from 'prop-types' | ||
| import React from 'react' | ||
|
|
||
| export default class ImageLoader extends React.Component { |
| children: PropTypes.func.isRequired | ||
| } | ||
|
|
||
| getCanvas() { |
There was a problem hiding this comment.
Won't this leak a new canvas into the document for every Resize instance?
There was a problem hiding this comment.
Whoops, I had implemented a cWU that removed it, but it got missing in action obviously. Added it back now. Thanks!
rexxars
approved these changes
Feb 5, 2018
kristofferjs
pushed a commit
that referenced
this pull request
Feb 12, 2018
* [imagetool] Scale down large images before passing to ImageTool * [imagetool] Remove canvas element on cWU * [imagetool] Fix incorrect class name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will scale down large images before passing on to the ImageTool component. It's a defensive fix to ensure the imagetool works even if you give it a huge image.
This is just an internal refactoring, the public API stays the same.
It is also a good idea to scale down the images before fetching from the CDN, but that's a separate task.