Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mutator] Fix/mutation rev shortcomings #551

Merged
merged 3 commits into from
Feb 1, 2018
Merged

[mutator] Fix/mutation rev shortcomings #551

merged 3 commits into from
Feb 1, 2018

Conversation

simen
Copy link
Member

@simen simen commented Jan 31, 2018

No description provided.

@simen simen requested a review from bjoerge January 31, 2018 21:46
bjoerge
bjoerge approved these changes Feb 1, 2018
View reviewed changes
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simen simen merged commit 290114f into next Feb 1, 2018
@bjoerge bjoerge deleted the fix/mutation-rev-shortcomings branch February 1, 2018 09:01
bjoerge pushed a commit that referenced this pull request Feb 1, 2018
@simen @bjoerge
[mutator] Fix/mutation rev shortcomings (#551)
2781311 
In some cases (specifically, no-op patches) the _rev marker on documents patched optimistically on the front end would not respect immutability and thus modify _rev of versions that should retain old value. This patch ensures documents that are patched are always unique objects whenever the _rev is updated.
bjoerge pushed a commit that referenced this pull request Feb 1, 2018
@simen @bjoerge
[mutator] Fix/mutation rev shortcomings (#551)
b1ddb43 
In some cases (specifically, no-op patches) the _rev marker on documents patched optimistically on the front end would not respect immutability and thus modify _rev of versions that should retain old value. This patch ensures documents that are patched are always unique objects whenever the _rev is updated.
rexxars pushed a commit that referenced this pull request Feb 5, 2018
@simen @rexxars
[mutator] Fix/mutation rev shortcomings (#551)
50519e9 
In some cases (specifically, no-op patches) the _rev marker on documents patched optimistically on the front end would not respect immutability and thus modify _rev of versions that should retain old value. This patch ensures documents that are patched are always unique objects whenever the _rev is updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoerge bjoerge bjoerge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simen @bjoerge