Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(import-cli): upgrade meow dependency #2755

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Sep 8, 2021

Description

Upgrades the meow dependency to the latest version that still supports node.js 10. This fixes a security issue that Snyk reported: #2735

Closes #2735

What to review

  • Run the CLI tool and make sure it parses the flags correctly (it should, from my testing)
packages/@sanity/import-cli$ node src/sanity-import.js -p abc123 -d dataset --token=foo --replace --allow-failing-assets some-source.ndjson

Notes for release

None (invisible for end-user)

@vercel
Copy link

vercel bot commented Sep 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

perf-studio – ./

🔍 Inspect: https://vercel.com/sanity-io/perf-studio/9KWCsSbnpLryvC1kExrcFjBm51XQ
✅ Preview: https://perf-studio-git-chore-upgrade-import-meow.sanity.build

test-studio – ./

🔍 Inspect: https://vercel.com/sanity-io/test-studio/AM33W6gqP2Q7D2CUpoGu1GQBNYMt
✅ Preview: https://test-studio-git-chore-upgrade-import-meow.sanity.build

Copy link
Member

@skogsmaskin skogsmaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As you have tested it I trust that it works :)

@rexxars rexxars merged commit 03781c9 into next Sep 8, 2021
@rexxars rexxars deleted the chore/upgrade-import-meow branch September 8, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants