Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base] Hide loading screen when tab is not visible #459

Closed
rexxars opened this issue Jan 5, 2018 · 0 comments
Closed

[base] Hide loading screen when tab is not visible #459

rexxars opened this issue Jan 5, 2018 · 0 comments
Assignees
Labels

Comments

@rexxars
Copy link
Member

rexxars commented Jan 5, 2018

The new loading screen that fades in/out is pretty nice, but sometimes you are developing a feature without the browser open. Because the changes are live-reloaded, the loading screen will reappear on change, but it doesn't actually start fading out until you focus the tab.

This is a slight annoyance to me when the page is actually ready to go but not visible right away. Could we check document.visibilityState to see if the tab is hidden and if so instantly hide the loading screen?

@rexxars rexxars added the dx label Jan 5, 2018
kristofferjs pushed a commit that referenced this issue Feb 9, 2018
#573)

* [default-layout] Use visibilityState to hide loadingScreen. Fixes #459

* [default-layout] OR, not AND
kristofferjs pushed a commit that referenced this issue Feb 12, 2018
#573)

* [default-layout] Use visibilityState to hide loadingScreen. Fixes #459

* [default-layout] OR, not AND
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants