Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omitting tool icon should not fail #33

Closed
bjoerge opened this issue Feb 28, 2017 · 1 comment
Closed

Omitting tool icon should not fail #33

bjoerge opened this issue Feb 28, 2017 · 1 comment

Comments

@bjoerge
Copy link
Member

bjoerge commented Feb 28, 2017

The tool switcher seems to try to use <tool.icon /> without any checks, expecting tool.icon to be a valid react component, which fails if its not.

Side note: It currently looks like no tool icons are displayed at all.
@bjoerge
Copy link
Member Author

bjoerge commented Oct 13, 2017

Looks like this was fixed in 8e63903:

sanity/packages/@sanity/default-layout/src/components/ToolSwitcher.js

Line 18 in 8e63903

const ToolIcon = tool.icon || PluginIcon

@bjoerge bjoerge closed this as completed Oct 13, 2017
kristofferjs added a commit that referenced this issue Feb 5, 2018
@kristofferjs
[components] Inherit color on state colored dialogs. Fixes #33
a573a31
kristofferjs pushed a commit that referenced this issue Feb 6, 2018
[components] Inherit color on state colored dialogs. Fixes #33 (#571)
7308de4
kristofferjs pushed a commit that referenced this issue Feb 6, 2018
[form-builder] Center with flex. Fixes #79 (#577)
5c8eef1 
* [components] Inherit color on state colored dialogs. Fixes #33 (#571)

* [form-builder] Center with flex. Fixes #79
kristofferjs pushed a commit that referenced this issue Feb 12, 2018
@kristofferjs
[form-builder] Center with flex. Fixes #79 (#577)
4ddb20e 
* [components] Inherit color on state colored dialogs. Fixes #33 (#571)

* [form-builder] Center with flex. Fixes #79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rexxars @bjoerge