[form-builder] Optimize selectionchange event handlers in Formbuilder…

…Block/FormBuilderInline (#555)
sanity-io · Feb 4, 2018 · c6407a8 · c6407a8
1 parent f695eab
commit c6407a8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/packages/@sanity/form-builder/src/inputs/BlockEditor-slate/FormBuilderBlock.js b/packages/@sanity/form-builder/src/inputs/BlockEditor-slate/FormBuilderBlock.js
@@ -110,6 +110,9 @@ export default class FormBuilderBlock extends React.Component {
   }
 
   handleSelectionChange = event => {
+    if (!this._editorNode.contains(event.target)) {
+      return
+    }
     const selection = document.getSelection()
     const isSelected = selection.containsNode
         && selection.containsNode(this.formBuilderBlock)

diff --git a/packages/@sanity/form-builder/src/inputs/BlockEditor-slate/FormBuilderInline.js b/packages/@sanity/form-builder/src/inputs/BlockEditor-slate/FormBuilderInline.js
@@ -87,6 +87,9 @@ export default class FormBuilderInline extends React.Component {
   }
 
   handleSelectionChange = event => {
+    if (!this._editorNode.contains(event.target)) {
+      return
+    }
     const selection = document.getSelection()
     const isSelected = selection.containsNode
         && selection.containsNode(this.formBuilderInline)