Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support how renovatebot generate lockfiles #47

Merged
merged 1 commit into from
Nov 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ jobs:
with:
cache: npm
node-version: ${{ matrix.node }}
- run: npm ci
- run: npm i
- run: npm test

release:
Expand Down
2 changes: 1 addition & 1 deletion assets/inject/semver-workflow/.github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:
with:
cache: npm
node-version: ${{ matrix.node }}
- run: npm ci
- run: npm i
- run: npm test --if-present

release:
Expand Down
13 changes: 6 additions & 7 deletions docs/semver-workflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ semantic-release driven workflow on Github for Sanity v3 plugins.

### 1. Install new dependencies

Run
Run

```bash
npm install
```
Expand All @@ -33,13 +34,14 @@ on:
branches: [main, v3]
```

### 4. Check secrets
### 4. Check secrets

Ensure that your repo or Github org has set the secrets used by the workflow.

`secrets.GITHUB_TOKEN` should always be available by default, but
`secrets.NPM_PUBLISH_TOKEN` is not.
`secrets.NPM_PUBLISH_TOKEN` is not.

Secrets can be set using `Settings -> Secrets -> Actions -> "New reposiotry secret"`
Secrets can be set using `Settings -> Secrets -> Actions -> "New repository secret"`
on Github for a repository.

### 5. Update .releaserc.json
Expand Down Expand Up @@ -88,6 +90,3 @@ semantic-release driven workflow on Github.
- Adds husky and related files and dependencies to do pre-commit checks
- Adds semantic-release and preset dependencies to automate npm & Github releases
- Updates README.md with some standard texts