Skip to content

Commit

Permalink
fix: added parcel to deprecated dependencies check
Browse files Browse the repository at this point in the history
  • Loading branch information
snorrees committed Nov 2, 2022
1 parent 308c0d0 commit 6172dcb
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 2 deletions.
3 changes: 3 additions & 0 deletions assets/inject/gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,6 @@ jspm_packages
# Yalc
.yalc
yalc.lock

##npm package zips
*.tgz
4 changes: 3 additions & 1 deletion src/actions/verify-package.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ export async function verifyPackage({basePath, flags}: {basePath: string; flags:
await validation('babelConfig', async () => validateBabelConfig({basePath}))

await validation('dependencies', async () => validateSanityDependencies(packageJson))
await validation('dependencies', async () => validateDeprecatedDependencies(packageJson))
await validation('deprecatedDependencies', async () =>
validateDeprecatedDependencies(packageJson)
)
await validation('eslintImports', async () => validateImports({basePath}))

if (errors.length) {
Expand Down
1 change: 1 addition & 0 deletions src/actions/verify/verify-common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export const verifyPackageConfigDefaults = {
tsconfig: true,
tsc: true,
dependencies: true,
deprecatedDependencies: true,
babelConfig: true,
sanityV2Json: true,
eslintImports: true,
Expand Down
8 changes: 7 additions & 1 deletion src/configs/banned-packages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,10 @@ export const mergedPackages = [
'@sanity/studio-hints',
].sort()

export const deprecatedDevDeps = ['tsdx', 'sanipack']
export const deprecatedDevDeps = [
'tsdx',
'sanipack',
'parcel',
'@parcel/packager-ts',
'@parcel/transformer-typescript-types',
]

0 comments on commit 6172dcb

Please sign in to comment.