Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Pipeline Update #95

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

bradley
Copy link

@bradley bradley commented Nov 12, 2020

Updates gatsby-source-sanity to support passing a subset of Sanity's Image Pipeline transformations when making calls via GraphQL or through the image utility functions.

References: #89

@bradley
Copy link
Author

bradley commented Nov 12, 2020

I wanted to add, you'll notice that @types/react-dom is added to the dependencies in package.json. I was unable to build the built version of this package without adding this, and confused as to why this was necessary and why it was not in the current codebase.

If anyone who knows could clear that up prior to merging, that would be useful.

@riccardogiorato
Copy link

Is it possible to merge this PR @rexxars or any other sanity team member?

@codingwithchris
Copy link

codingwithchris commented Jan 17, 2021

@rexxars + Sanity Team: Bump on this PR or building a similar set of features yourselves.

This is a big sticking point for me. I just did a massive migration from Prismic to Sanity and I'm LOVING pretty much everything except for the image transformations. Prismic has a full suite of imgix transforms available as GraphQL params. I was using these params to desaturate my images and set variable image quality based on usage. I'm really missing these features now.

@darylthornhill
Copy link

Tagged as triaged, but is this actually in now? We cant add quality in still. I can create a PR if necessary just for quality. I've fixed it with patch-package temporarily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants