websocket_handshake invalid function signature

[cnicodeme]

Describe the bug
The function websocket_handshake located in sanic.server.protocols.websocket_protocol has an invalid signature in Sanic 21.9.2 (at least)

Code snippet
Current code is:

    async def websocket_handshake(
        self, request, subprotocols=Optional[Sequence[str]]
    ):

Expected behavior
Code should be:

    async def websocket_handshake(
        self, request, subprotocols:Optional[Sequence[str]] = None
    ):

=> Typing should be set with ":", not "=" ;)

Environment (please complete the following information):

• Version 21.9.2

[ahopkins]

@cnicodeme Can you add a PR for this, and I can get a patch released this weekend.

[cnicodeme]

Let me know if that works :)

[ahopkins]

Awesome thanks. I'll take a look at why it's failing tomorrow 😎

I appreciate you calling this out and fixing it.

[cnicodeme]

You are welcome! That was an easy one to fix ;)

(But I don't know why it refuses my PR, maybe some wrong code formatting)

[ahopkins]

That could be. I'm on my phone so it's hard to see. Maybe line length? We run black on the code base so that might help.

If you run make pretty it should hopefully autofix.

[ahopkins]

Nope. Looks like mypy

tox -e type-checking

@ashleysommer Maybe related to what you said you were seeing?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is incorrect, please respond with an update. Thank you for your contributions.