review of the PR

sangwonl · Dec 19, 2023 · 8959478 · 8959478
1 parent 90793a9
commit 8959478
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -19,7 +19,7 @@ $ pip install mpegdash
 ## Test
 
 ```bash
-$ python3 -m unittest discover
+$ python -m unittest discover
 ```
 
 * * *

diff --git a/mpegdash/utils.py b/mpegdash/utils.py
@@ -18,7 +18,7 @@ def parse_child_nodes(xmlnode, tag_name, node_type):
 
     nodes = []
     for elem in elements:
-        if node_type is str:
+        if isinstance(node_type, str):
             node = xmlnode.firstChild.nodeValue
         else:
             node = node_type()
-Original file line number
+Diff line change
@@ Expand Up / @@ -19,7 +19,7 @@ $ pip install mpegdash @@
     ## Test
     ```bash
-    $ python3 -m unittest discover
+    $ python -m unittest discover
     ```
     * * *
@@ Expand Down @@