Fix: Schema rendering problems with Windows line separators

[ArminWiebigke]

Fix #1125

[yanns]

Thanks a lot! I very like the test case you added!

The CI checks are failing with a compilation error:

[error] /home/runner/work/sangria/sangria/modules/core/src/main/scala/sangria/renderer/QueryRenderer.scala:480:63: value iterator is not a member of Iterator[String]
[error]       val lines = escapeBlockString(node.value).linesIterator.iterator.map { line =>
[error]     

Do you want to take care of this?

[yanns]

One test seem to fail:

[info]   - should renders comments with various line separators correctly *** FAILED ***
[info]     "..._LF:
[info]     
[info]     __CRLF:
[info]     
[info]     __CR:[

]Empty_lines_above_sh..." did not equal "..._LF:
[info]     
[info]     __CRLF:
[info]     
[info]     __CR:[
[info]     
[info]     __]Empty_lines_above_sh..." (QueryRendererSpec.scala:1018)
[info]     Analysis:
[info]     "..._LF:
[info] 
[info] __CRLF:
[info] 
[info] __CR:[

[ArminWiebigke]

Seems like \r is not considered a valid line break in Scala 2.12.19 🤔
So I guess we just need to split manually in case any \rs are still contained in the lines returned by linesIterator.

[yanns]

Seems like \r is not considered a valid line break in Scala 2.12.19 🤔 So I guess we just need to split manually in case any \rs are still contained in the lines returned by linesIterator.

Having some code just for scala 2.12 is not optimal.
Why if we would copy / paste the implementation of linesIterator into our code (I mean the implementation that is also considering \r)?

[yanns]

💯

[yanns]

I was checking the specs, and your code seems to be compliant with it: https://spec.graphql.org/October2021/#LineTerminator