Y24-353 Fix for Missing data on edit for ONT runs #1983
Conversation
…d' and 'create' functions.
I actually tried it, but it didn't work as I expected. Might need bit more time looking into it. |
OK. Let's timebox it and if needed roll it into it's own story. It may well be an issue with the page loading. The ONT run page is very slow to load. We do have a technical debt story somewhere. |
Ok. Also, it would be good to add similar e2e test cases for Pacbio Pool, Runs etc. for the same reason |
I have created a story #1984 |
|
|
||
| // Check that the URL is correct | ||
| cy.url().should('include', '#/ont/run/2') | ||
| cy.get('#flowcell-id-1').invoke('val').should('eq', 'ABC1234') |
There was a problem hiding this comment.
Advisory. We should probably change this so it relates to the store data but I suggest we do that at another time and get this story deployed.
Closes #1982
Changes proposed in this pull request
Update the 'include' parameter in the 'find' and 'create' method of createRequest so that destructuring of parameters works as in v1
Correct unit test cases to replicate the way it is called from stores
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version