Skip to content

[Backport] Declare module namespace before template path name(Magento_Sales::order/creditmemo.phtml).#8

Merged
sanganinamrata merged 161 commits into2.1-developfrom
2.1-develop-PR-port-16481
Oct 1, 2019
Merged

[Backport] Declare module namespace before template path name(Magento_Sales::order/creditmemo.phtml).#8
sanganinamrata merged 161 commits into2.1-developfrom
2.1-develop-PR-port-16481

Conversation

@sanganinamrata
Copy link
Copy Markdown
Owner

Original Pull Request

magento#16481

Description

When we override block creditmemo(Magento\Sales\Block\Order\Creditmemo) to my custom module.
It throws an error and finding order/creditmemo.phtml in my custom module.
I tried to extend Block Magento\Sales\Block\Order\Creditmemo from my custom module.

1 exception(s):
Exception #0 (Magento\Framework\Exception\ValidatorException): Invalid template file: 'order/creditmemo.phtml' in module: 'Vendor_Module' block's name: 'sales.order.creditmemo'

Fixed Issues (if relevant)

  1. Declare module namespace before template path name.
    protected $_template = 'Magento_Sales::order/creditmemo.phtml';

Manual testing scenarios

  1. I override creditmemo block

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

omiroshnichenko and others added 30 commits April 25, 2018 14:38
…d and bundle folder contains any other files
[thunder] MAGETWO-90925: Wrong case in classname CLI in ProcessCronQueueObserver
-[MAGETWO-90925] (https://jira.corp.magento.com/browse/MAGETWO-90925) Wrong case in classname CLI in ProcessCronQueueObserver
Merge branch '2.1' of github.com:magento/magento2ce into 2.1.14-develop-update
[TSG] Backporting for 2.1 (pr53) (2.1.14)
…update

[Plankton] Merge release to 2.1.14-develop
Added one more empty line
magento-engcom-team and others added 28 commits June 30, 2018 08:05
…nto#16467

 - Merge Pull Request magento#16467 from gelanivishal/magento2:2.1-develop-PR-port-14029
 - Merged commits:
   1. d2a3065
… name(Magento_Sales::order/info.phtml). magento#16475

 - Merge Pull Request magento#16475 from gelanivishal/magento2:2.1-develop-PR-port-16206
 - Merged commits:
   1. 18f255b
Accepted Public Pull Requests:
 - magento#16467: [Backport] Fix $useCache for container child blocks (by @gelanivishal)
- Merge tag '2.1.14' into 2.1-develop
Accepted Public Pull Requests:
 - magento#16475: [Backport] Declare module namespace before template path name(Magento_Sales::order/info.phtml). (by @gelanivishal)
[Plankton]: Merge 2.1.14 Release into 2.1-develop Branch
 - Merge Pull Request magento#16491 from gelanivishal/magento2:2.1-develop-PR-port-16213
 - Merged commits:
   1. f0a8ba8
   2. f388069
…eButtonText magento#16229

 - Merge Pull Request magento#16229 from Karlasa/magento2:2.1-develop-PR-port-16190
 - Merged commits:
   1. d09dbe4
   2. f523032
Accepted Public Pull Requests:
 - magento#16491: Fix for magento#8222 (by @gelanivishal)
 - magento#16392: [Backport]Fixes updating wishlist item if an item object is passed instead its id. (by @eduard13)
 - magento#16229: [Backport] magento#16079 translation possibility for moreButtonText (by @Karlasa)


Fixed GitHub Issues:
 - magento#8222: Estimate Shipping and Tax Form not works due to js error in collapsible.js [proposed fix] (reported by @Dart18) has been fixed in magento#16491 by @gelanivishal in 2.1-develop branch
   Related commits:
     1. f0a8ba8
     2. f388069

 - magento#16079: Need information about translating issue (Magento Swatches Js) (reported by @mageho) has been fixed in magento#16229 by @Karlasa in 2.1-develop branch
   Related commits:
     1. d09dbe4
     2. f523032
…to#16547

 - Merge Pull Request magento#16547 from gelanivishal/magento2:2.1-develop-PR-port-15993
 - Merged commits:
   1. 56684c1
   2. 9735078
   3. 0040a1c
Accepted Public Pull Requests:
 - magento#16547: Correct return type of methods and typo correction (by @gelanivishal)
sanganinamrata pushed a commit that referenced this pull request Jul 25, 2018
@sanganinamrata sanganinamrata merged commit 2f3ec1b into 2.1-develop Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.