Fix ConsoleLogging log level handling#358
Merged
sandrohanea merged 1 commit intosandrohanea:mainfrom Mar 13, 2025
Merged
Conversation
Owner
|
Hello @umlx5h , Thanks for your contribution! |
sandrohanea
added a commit
that referenced
this pull request
Mar 20, 2025
sandrohanea
added a commit
that referenced
this pull request
Mar 29, 2025
* Fixed severity order (Higher values are less severe) See #358 * Bumped whisper.cpp and changed the versioning readme * Added some extra logs on vulkan build * aa * Tried to fix vulkan * aaa * dsds * dasd * Fix * fsd * Updated whisper.cpp to latest experiment * Tried to disable BMI2 on Win32 * OFF * Bumped whisper.cpp to latest commit in PR * One more of * Removed CROSS_COMPILE a bit (will revert) just for CI and checking the vulkan build like that as well * reverted vulkan build to cross-compile * Again * removed cross-compile for triggering CI like that * updated whisper.cpp --------- Co-authored-by: Sandro Hanea <me@sandro.rocks>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only logs INFO or higher when it is executed.
I thought the expected behavior was to also output DEBUG, so I modified the condition.
Although not directly related to PR, the order of these log levels seemed strange to me.
whisper.net/Whisper.net/Logger/WhisperLogLevel.cs
Lines 4 to 12 in 26ea3be
I think ERROR is more severe than INFO, not less severe, as stated in the comments below.
https://github.com/umlx5h/whisper.net/blob/26ea3be73ef12dc3f1605e0d9eb0065736b64dd7/Whisper.net/Logger/LogProvider.cs#L21