Fixed vulkan and coreml targets #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the build configurations for the Whisper.net runtime, specifically targeting different platforms and frameworks. The most important changes involve adding support for Metal and Vulkan assets and ensuring proper handling of these assets across various platforms.
Updates to Metal and Vulkan asset handling:
runtimes/Whisper.net.Runtime.CoreML/Whisper.net.Runtime.CoreML.targets: Added conditions to include theggml-metal.metalasset for maccatalyst, iOS, tvOS, and their simulators, and ensured the asset is copied correctly for MacOS targets.runtimes/Whisper.net.Runtime.Vulkan/Whisper.net.Runtime.Vulkan.targets: Introduced a new project file to handle Vulkan assets for Windows targets, ensuring thewhisper.dllandggml.dllare included and copied to the output directory.