Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status error nodes #57

Merged
merged 8 commits into from
Aug 26, 2024
Merged

Status error nodes #57

merged 8 commits into from
Aug 26, 2024

Conversation

Aptimex
Copy link
Collaborator

@Aptimex Aptimex commented Aug 21, 2024

Peers that have connection errors when running status now get displayed nicely as individual nodes with their error message.

Example:

./wiretap status

╭────────────────────────╮ 
│ Wiretap Network Status │                                                                                                                                                                                                                                                                                                 
╰────────────┬───────────╯                                                                                                                                                                                                                                                                                                 
             │                                                                                                                                                                                                                                                                                                             
  ╭──────────┴──────────╮                                                                                                                                                                                                                                                                                                  
  │client               │                                                                                                                                                                                                                                                                                                  
  │                     │                                                                                                                                                                                                                                                                                                  
  │  relay: VstrCYL4... │                                                                                                                                                                                                                                                                                                  
  │   e2ee: mRpj/ROf... │                                                                                                                                                                                                                                                                                                  
  │                     │                                                                                                                                                                                                                                                                                                  
  ╰──────────┬──────────╯                                                                                                                                                                                                                                                                                                  
             │                                                                                                                                                                                                                                                                                                             
  ╭──────────┴──────────╮                                                                                                                                                                                                                                                                                                  
  │server               │                                                                                                                                                                                                                                                                                                  
  │  relay: WfcMfolr... │                                                                                                                                                                                                                                                                                                  
  │   e2ee: ypb3PEu4... │                                                                                                                                                                                                                                                                                                  
  │                     │                                                                                                                                                                                                                                                                                                  
  │    api: ::2         │                                                                                                                                                                                                                                                                                                  
  │ routes: 10.0.0.0/24 │                                                                                                                                                                                                                                                                                                  
  ╰─────────────────────╯                                                                                                                                                                                                                                                                                                  
                                                                                                                                                                                                                                                                                                                           

Peers with Errors:

╭───────────────────────────────────────────────────────────────────────────────────╮
│server                                                                             │                                                                                                                                                                                                                                      
│                                                                                   │                                                                                                                                                                                                                                      
│     e2ee: d8qA4mVI...                                                             │                                                                                                                                                                                                                                      
│      api: 1::2                                                                    │                                                                                                                                                                                                                                      
│   routes: 10.105.0.0/16                                                           │                                                                                                                                                                                                                                      
│                                                                                   │                                                                                                                                                                                                                                      
│ error: Get "http://1::2:80/serverinfo?": context deadline exceeded (Client.Timeout│                                                                                                                                                                                                                                      
│        exceeded while awaiting headers)                                           │                                                                                                                                                                                                                                      
╰───────────────────────────────────────────────────────────────────────────────────╯

@Aptimex Aptimex linked an issue Aug 21, 2024 that may be closed by this pull request
@Aptimex Aptimex requested a review from luker983 August 21, 2024 23:02
@Aptimex
Copy link
Collaborator Author

Aptimex commented Aug 21, 2024

TODO: also include server Nickname in the error node after that PR gets merged. Done

Copy link
Collaborator

@luker983 luker983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change 👍 👍

src/cmd/status.go Outdated Show resolved Hide resolved
src/cmd/status.go Outdated Show resolved Hide resolved
src/cmd/status.go Show resolved Hide resolved
@Aptimex
Copy link
Collaborator Author

Aptimex commented Aug 24, 2024

Merged nickname code from main, now shows server nicknames in error nodes too.

src/cmd/status.go Outdated Show resolved Hide resolved
Co-authored-by: Luke Rindels <[email protected]>
@Aptimex Aptimex merged commit 342aa4e into main Aug 26, 2024
3 checks passed
@Aptimex Aptimex deleted the status-error-nodes branch August 26, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display unconnected servers (and associated errors) in status command
2 participants