Remove unused isin #458
Merged
Remove unused isin #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreyostrove
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Thanks as always for your help, @eendebakpt!
I agree that this doesn't appear to be used at present, so I don't seen any reason not to remove the import.
Edit: Switched the base branch to develop from master.
sserita
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Looks good, thanks @eendebakpt!
Thanks @coreyostrove for catching the branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import of
isinused is not availabe in numpy 2.0. If the import is required for backwards compatibility, then I suggest to replace it withfrom numpy import isin